build: don't directly use the .libs directory #3097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build system should not directly use the .libs directory which is intended for internal use by the libtool implementation. Additionally when linking with internal a library the .la file should be used as this provides all the information required by the libtool implementation. When using Slibtool instead of GNU Libtool the build fails because Slibtool is more strict about this and fails to find the required files to link with.
|
|
Trying to split the changes in half didn't seem to make a difference for Quality Gate.... |
Yeah, QG check is very weird - I'm sure that's a false positive hit (the code is definitely not NEW). I have to find a solution - sorry, and thanks for your patience. |
No worries and thanks for your time! |
|
ping @orbea |
|
May be we will copy this PR and send it again. Meanwhile the CI workflow had changed a lot (eg. see the Windows support), so we insist to run the whole test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of PR #2980 to try to trigger the CI regression tests.
The build system should not directly use the
.libsdirectory which is intended for internal use by the libtool implementation. Additionally when linking with internal a library the.lafile should be used as this provides all the information required by the libtool implementation.When using Slibtool instead of GNU Libtool the build fails because Slibtool is more strict about this and fails to find the required files to link with.
Gentoo Bug: https://bugs.gentoo.org/913484