-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sonarcloud memleak fixes #3114
fix: Sonarcloud memleak fixes #3114
Conversation
This block makes no sense. The variable is initialized as an empty string in line 49 in each cycle. 49. std::string argFull(""); therefore the condition's left side ( 54. if (argFull.empty() == false) { is always So I'm going to remove it. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot simpler, thanks.
Quality Gate passedIssues Measures |
This pull request fixes two memory leaks, reported by SonarCloud.
None of them modified the library itself.