Memory leaks + enhanced logging #3156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systematically log problems in update_rule_target_ex(). Fix some memory leaks in update_rule_target_ex().
airween
reviewed
May 28, 2024
| if(target_list == NULL) | ||
| return apr_psprintf(ruleset->mp, "Error to update target - memory allocation");; | ||
| if (target_list == NULL) { | ||
| my_error_msg = apr_psprintf(ruleset->mp, "Error to update target - memory allocation"); |
There was a problem hiding this comment.
Here (and at some other cases) you removed the return statement and after set of my_error_msg you jump to the label end. There you call an msr_log(msr, 9, my_error_msg) and always return with NULL.
But the calling places return this value, so may be that char * needs there - isn't it?
There was a problem hiding this comment.
You're right, I fixed the return value
|
|
replaced by #3191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log audit lock name in case of problem.
Systematically log problems in update_rule_target_ex().
Fix some memory leaks in update_rule_target_ex().