Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR's to CHANGES #3205

Merged
merged 10 commits into from
Sep 3, 2024
Merged

Conversation

airween
Copy link
Member

@airween airween commented Aug 3, 2024

what

Add PR's to CHANGES

why

PR's weren't added during the merge process.

@airween airween added 2.x Related to ModSecurity version 2.x do not merge labels Aug 3, 2024
@airween
Copy link
Member Author

airween commented Aug 3, 2024

Do not approve nor merge this yet.

@airween airween requested a review from theseion September 2, 2024 20:21
@airween
Copy link
Member Author

airween commented Sep 2, 2024

I think it's done, I do not want to add anything else. I removed [do not merge] label.

CHANGES Outdated Show resolved Hide resolved
CHANGES Outdated Show resolved Hide resolved
@theseion
Copy link
Collaborator

theseion commented Sep 3, 2024

Maybe for the next release, consider going the same way as CRS and dropping the changes file in favour of the auto generated changelog through GitHub releases.

Copy link

sonarcloud bot commented Sep 3, 2024

@airween
Copy link
Member Author

airween commented Sep 3, 2024

Maybe for the next release, consider going the same way as CRS and dropping the changes file in favour of the auto generated changelog through GitHub releases.

Thanks, we need to inspect this possibility. I added your suggestions - thanks.

@airween airween requested a review from theseion September 3, 2024 05:44
@airween airween merged commit bf1a3be into owasp-modsecurity:v2/master Sep 3, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to ModSecurity version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants