Adjust reference to modsecurity::utils::string::VALID_HEX

[eduar-hte]

what

Fix build after integrating PR #3231 & #3233 because of reference to modsecurity::utils::string::VALID_HEX in pm.cc's parse_pm_content.

why

These two PRs were independent of each other, but when we added a reference to VALID_HEX to simplify the code, we introduced an incompatibility between both PRs because PR #3231 moved VALID_HEX into the namespace modsecurity::utils::string (alongside all other helper functions in src/utils/string.h) and adjusted all call sites to this function (previously a macro). However, in that branch the call added to parse_pm_content that we introduced later in PR #3233 was not present and thus was not adjusted.

[airween]

Ahm, thanks - meanwhile I also started to work on this fix 😄

Btw I don't understand the situation, because the PR's check were successful, but later I get reports about failed checks.

Seems like now everything is fine.

I also added two new tests (a positive and a negative) - do you think that would be useful to check the @pm's correct behavior? If yes, could you pick up those modifications?

[eduar-hte]

Btw I don't understand the situation, because the PR's check were successful, but later I get reports about failed checks.

VALID_HEX used to live in the global namespace because it was a macro (#define), and in PR #3231 I converted it to a function (in order to continue removing preprocessor dependencies), and the function was included in the namespace modsecurity::utils::string (alongside the rest of the functions in src/utils/string.h, which is where VALID_HEX was defined).

You can see in commit a6d64bf that I adjusted the source files that were using this macro because the macro/function was no longer in the global namespace.

When we introduced the use of VALID_HEX in PR #3233 to simplify the code in parse_pm_content, a new reference to this macro/function was introduced, which needed to be adjusted to the namespace change.

I also added two new tests (a positive and a negative) - do you think that would be useful to check the @pm's correct behavior? If yes, could you pick up those modifications?

ok, I'll do that and push an update to this PR.

[eduar-hte]

ok, I'll do that and push an update to this PR.

done. I added your repository as a remote in my local repository in order to cherry-pick your commit and preserve your authorship. :-)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[airween]

in PR #3231 I converted it to a function

Oh, thanks - I didn't noticed that. I looked up for that and found as macro so that was confused.

Never mind, thanks for all again. If the tests will passed I'm going to merge this PR.

[airween]

Hmm... after this PR was merged, I receive notifications about failed tests, especially on macOS, with SecRemoteRules - like this one.

Never mind, may be I forget to update that branch where I get from the notifications.