Set sprocket-rails version to be at least 3.5.1 and fix rubocop issues #1072

texpert · 2024-06-06T20:00:22Z

With the release of sprockets-rails 3.5.0, our local test suite breaks with:

NoMethodError: undefined method `deprecator' for Sprockets::Rails:Module
Did you mean?  deprecate
/home/runner/work/camaleon-cms/camaleon-cms/vendor/bundle/ruby/3.0.0/gems/sprockets-rails-3.5.0/lib/sprockets/railtie.rb:129:in `block in <class:Railtie>'
/home/runner/work/camaleon-cms/camaleon-cms/vendor/bundle/ruby/3.0.0/gems/railties-7.1.3.4/lib/rails/initializable.rb:32:in `instance_exec'

A bug fixing PR has already been merged - see rails/sprockets-rails#525, so let's set sprocket-rails version to be greater or equal to 3.5.1, which is working good.

`Error: The `RSpec/FilePath` cop has been split into `RSpec/SpecFilePathFormat` and `RSpec/SpecFilePathSuffix`. (obsolete configuration found in .rubocop.yml, please update it)`

…oller and suppress in nav_menu_helper `

…, RSpec/ExcessiveDocstringSpacing: Excessive whitespace, RSpec/NoExpectationExample: No expectation found in this example `

…n this example in models/user_spec `

… helpers/email_helper_spec `

…ts in helpers/short_code_helper_spec

…mplifying the logic to not use exceptions at all

brian-kephart

Sorry for the delay @texpert . This PR looks good. Thanks for doing this.

Restrict sprocket-rails to version up to 3.4.2

d664ec3

texpert requested review from owen2345 and brian-kephart June 6, 2024 20:08

texpert added 2 commits June 11, 2024 14:45

Restrict minimal sprocket-rails to version 3.5.1

f000a00

Fix rubocop error

6a945b3

`Error: The `RSpec/FilePath` cop has been split into `RSpec/SpecFilePathFormat` and `RSpec/SpecFilePathSuffix`. (obsolete configuration found in .rubocop.yml, please update it)`

texpert changed the title ~~Restrict sprocket-rails to version up to 3.4.2~~ Set sprocket-rails version to be at least 3.5.1 Jun 11, 2024

texpert added 8 commits June 11, 2024 20:07

Fix rubocop error Lint/ShadowingOuterLocalVariable in nav_menus_contr…

9bdf1df

…oller and suppress in nav_menu_helper `

Fix rubocop errors RSpec/MetadataStyle: Use symbol style for metadata…

fb9b712

…, RSpec/ExcessiveDocstringSpacing: Excessive whitespace, RSpec/NoExpectationExample: No expectation found in this example `

Fix rubocop errors RSpec/NoExpectationExample: No expectation found i…

824fd11

…n this example in models/user_spec `

Fix rubocop errors RSpec/ClassCheck: Prefer be_a over be_a_kind_of in…

adba156

… helpers/email_helper_spec `

Fix rubocop errors RSpec/BeEq: Prefer be over eq in models/ post_spec

6986184

Fix rubocop errors RSpec/Eq: Use eq instead of be == to compare objec…

1dc63cd

…ts in helpers/short_code_helper_spec

Fix rubocop errors Lint/SuppressedException in front_cache_helper, si…

b1a47e7

…mplifying the logic to not use exceptions at all

Update .rubocop_todo.yml

c6e6860

texpert changed the title ~~Set sprocket-rails version to be at least 3.5.1~~ Set sprocket-rails version to be at least 3.5.1 and fix rubocop issues Jun 11, 2024

brian-kephart approved these changes Jul 10, 2024

View reviewed changes

texpert merged commit 6074276 into owen2345:master Jul 12, 2024
13 checks passed

texpert deleted the restrict-sprockets-rails-to-3-4-2 branch August 21, 2024 17:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set sprocket-rails version to be at least 3.5.1 and fix rubocop issues #1072

Set sprocket-rails version to be at least 3.5.1 and fix rubocop issues #1072

texpert commented Jun 6, 2024 •

edited

Loading

brian-kephart left a comment

Set sprocket-rails version to be at least 3.5.1 and fix rubocop issues #1072

Set sprocket-rails version to be at least 3.5.1 and fix rubocop issues #1072

Conversation

texpert commented Jun 6, 2024 • edited Loading

brian-kephart left a comment

Choose a reason for hiding this comment

texpert commented Jun 6, 2024 •

edited

Loading