MetricStorage dtors (open-telemetry#1270)

owent · Mar 18, 2022 · 6bd2f96 · 6bd2f96
1 parent 0b1a74c
commit 6bd2f96
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.gitignore b/.gitignore
@@ -50,3 +50,4 @@
 /build
 
 tags
+.cache/clangd/*
diff --git a/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h b/sdk/include/opentelemetry/sdk/metrics/state/metric_storage.h
@@ -24,6 +24,8 @@ class MetricStorage
       opentelemetry::sdk::instrumentationlibrary::InstrumentationLibrary *instrumentation_library,
       opentelemetry::sdk::resource::Resource *resource,
       nostd::function_ref<bool(MetricData &)> callback) noexcept = 0;
+
+  virtual ~MetricStorage() = default;
 };
 
 class WritableMetricStorage
@@ -38,6 +40,7 @@ class WritableMetricStorage
 
   virtual void RecordDouble(double value,
                             const opentelemetry::common::KeyValueIterable &attributes) noexcept = 0;
+  virtual ~WritableMetricStorage() = default;
 };
 
 class NoopMetricStorage : public MetricStorage