Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel support #38

Merged
merged 8 commits into from
Jun 5, 2019
Merged

Add Laravel support #38

merged 8 commits into from
Jun 5, 2019

Conversation

owenvoke
Copy link
Owner

@owenvoke owenvoke commented Jun 3, 2019

Description

This adds full Laravel support with facades and app binding.

Usage examples:

// The app binding can be used as
app('arionum')->getNodeInfo();
app(Arionum::class)->getNodeInfo();

// The facade can be used as
Arionum::getNodeInfo();

Types of changes

Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Put an x in all the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #38 into develop will decrease coverage by 6.95%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #38      +/-   ##
=============================================
- Coverage        100%   93.04%   -6.96%     
- Complexity        62       66       +4     
=============================================
  Files              3        6       +3     
  Lines            214      230      +16     
=============================================
  Hits             214      214              
- Misses             0       16      +16
Impacted Files Coverage Δ Complexity Δ
src/Laravel/ArionumServiceProvider.php 0% <0%> (ø) 3 <3> (?)
src/Laravel/config/arionum.php 0% <0%> (ø) 0 <0> (?)
src/Laravel/ArionumFacade.php 0% <0%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff0b33...4afe65e. Read the comment docs.

@owenvoke owenvoke merged commit 4afe65e into develop Jun 5, 2019
@owenvoke owenvoke deleted the feature/laravel-support branch June 5, 2019 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant