Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

[WIP] Some bugfixes for the unread mail counter #1047

Closed
wants to merge 2 commits into from

Conversation

irgendwie
Copy link
Contributor

No description provided.

@jancborchardt
Copy link
Contributor

@irgendwie is this ready for review yet or still work in progress? :)

@irgendwie
Copy link
Contributor Author

Still work in progress @jancborchardt - it doesn't work completely and there are still some other bugs with the counter.

@irgendwie
Copy link
Contributor Author

Needs #122... to don't get hacky

@jancborchardt
Copy link
Contributor

@irgendwie #122 aliases seem to be entirely unrelated – sure you linked the right issue? ;)

@irgendwie
Copy link
Contributor Author

@jancborchardt For mails sent to an alias, I would need a hack to determine which account the mail belongs to (in the unified mailbox), because the message itself doesn't contain that information for mails with a different address than specified within the settings of the mail account.
If alias support is implemented, this issue would be fixed and I could just take the information, instead of writing a "dirty" workaround.

I think we have more than enough hacks in the mail app already.

@ChristophWurst
Copy link
Contributor

I think we have more than enough hacks in the mail app already.

Yes, indeed :)

@jancborchardt
Copy link
Contributor

Any updates here @irgendwie? Would be awesome to get this fixed :)

@irgendwie
Copy link
Contributor Author

@jancborchardt Sorry, currently working on my bachelor thesis and therefore no time for owncloud 😄

@jancborchardt
Copy link
Contributor

Ah, damn! :D Good luck then!

@Gomez
Copy link
Contributor

Gomez commented Mar 15, 2016

@irgendwie Can you finish?

@irgendwie
Copy link
Contributor Author

@Gomez Will take a look tomorrow!

@jancborchardt
Copy link
Contributor

@irgendwie tomorrow was yesterday. ;)

@irgendwie
Copy link
Contributor Author

@jancborchardt I know, did look into it -> stuff is handled differently now and the function isn't even called anymore. Need some time to get into the new code.
Maybe we should close this PR and create a new one.

@irgendwie irgendwie closed this Mar 25, 2016
@irgendwie irgendwie deleted the fix-some-unread-counter-bugs branch March 25, 2016 14:44
@ChristophWurst ChristophWurst restored the fix-some-unread-counter-bugs branch March 25, 2016 16:03
@ChristophWurst
Copy link
Contributor

@irgendwie can the branch be deleted?

@irgendwie irgendwie deleted the fix-some-unread-counter-bugs branch March 25, 2016 16:06
@irgendwie
Copy link
Contributor Author

Yes it can - the code isn't usable anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants