show first folder of an account incase of invalid folder id #1471
Conversation
|
By analyzing the blame information on this pull request, we identified @ChristophWurst to be a potential reviewer |
| // TODO: show first folder of this account | ||
| _this.default(); | ||
| return; | ||
| folder = account.get('folders').at(0); |
There was a problem hiding this comment.
Note: you could also use .first(), but .at(0) is also fine as it does the same thing ;-)
|
Changes look good, I'll test this later! Thanks a lot :-) |
|
@tahaalibra is there any case where this is currently used? (I don't really know how to test it) |
|
actually i am not sure if there are in test cases...i tested it with the browser, by simply entering owncloud/apps/mail#accounts/1/folders/(placing some random text) |
|
tahaalibra
force-pushed
the
show-first-folder-of-account
branch
from
27bcafa
to
04f2d0e
Compare
|
i messed up on rebase..i will fix this now |
tahaalibra
force-pushed
the
show-first-folder-of-account
branch
4 times, most recently
from
3c49bd2
to
27bcafa
Compare
|
@tahaalibra please rebase on current master, there should only be one commit. Let me know if you need help :) |
|
And please adjust the changelog accordingly, this fix is part of 0.4.5 not 0.4.4 ;-) |
tahaalibra
force-pushed
the
show-first-folder-of-account
branch
4 times, most recently
from
6b0c9cd
to
09c3486
Compare
ChristophWurst
force-pushed
the
show-first-folder-of-account
branch
2 times, most recently
from
4a6273f
to
0701389
Compare
|
👍 works perfectly! Thanks |
if the folder id is not found then the user will be sent to the first folder of that account
please review @ChristophWurst