First integration drone pipeline #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2018
| occ app:enable files_external >/dev/null 2>&1 | ||
| occ app:enable files_external >/dev/null 2>&1 | ||
| occ app:enable files_external || true >/dev/null 2>&1 | ||
| occ app:enable files_external || true >/dev/null 2>&1 |
There was a problem hiding this comment.
why the duplicated step?
There was a problem hiding this comment.
This is intentional because the first one sometimes fails. That have been suggested by @DeepDiver1975 in the past.
| rm -f ${OWNCLOUD_VOLUME_CONFIG}/marketplace.config.php | ||
| occ config:system:delete marketplace.key |
There was a problem hiding this comment.
Are you certain that this continues to work as expected - as far as I remember - when the configuration is changed the the file is rewritten, the settings end up in the config.php
There was a problem hiding this comment.
How should that command work when it's executed before the install step?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.