Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Logcat Android 11; optional live logging #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hannesa2
Copy link
Contributor

Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@abelgardep
Copy link
Contributor

Hey, @hannesa2 we got a conflict, could you take a look?

/android/owncloudApp/src/debug/AndroidManifest.xml:182:13-66 Error:
	Attribute provider#androidx.core.content.FileProvider@authorities value=(@string/file_provider_authority) from AndroidManifest.xml:182:13-66
	is also present at [com.github.AppDevNext.Logcat:LogcatCore:2.5.0] AndroidManifest.xml:25:13-60 value=(com.owncloud.android.debug.provider).
	Suggestion: add 'tools:replace="android:authorities"' to <provider> element at AndroidManifest.xml:180:9-188:20 to override.
/android/owncloudApp/src/debug/AndroidManifest.xml:187:17-58 Error:
	Attribute meta-data#android.support.FILE_PROVIDER_PATHS@resource value=(@xml/exposed_filepaths) from AndroidManifest.xml:187:17-58
	is also present at [com.github.AppDevNext.Logcat:LogcatCore:2.5.0] AndroidManifest.xml:30:17-55 value=(@xml/provider_paths).
	Suggestion: add 'tools:replace="android:resource"' to <meta-data> element at AndroidManifest.xml to override.

@hannesa2
Copy link
Contributor Author

hannesa2 commented Apr 6, 2021

The library needs the provider too, but it conflicts with yours, this is not a big thing, but there are several ways to solve

  • overwrite it
  • make it unique
  • make it dynamic
  • use it from library

yours: you use a string to access it in source too. Next to advantages, it has disadvantages concerning coexist of debug and release version on same devices.

    <provider
        android:name="androidx.core.content.FileProvider"
        android:authorities="@string/file_provider_authority"

Library uses dynamic values

    <provider
        android:name="androidx.core.content.FileProvider"
        android:authorities="${applicationId}.provider"

The paths differs too

yours:

<paths>
    <external-path
        name="file"
        path="/" />
</paths>

library:

<paths>
    <external-path
        name="external_files"
        path="." />
</paths>

I will make a proposal in app

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants