You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also we might want to consider to upgrade to Java 8 since that comes very in handy with lambda expressions, which is good because less ugly Java code -> better readable.
I've worked on the android app code for a little while now, and found some code which could be refactored or even removed. Here is my list:
Things to DELETE
Classes not in use anymore
android/src/com/owncloud/android/ui/NavigationDrawerItem.java
Line 23 in 988375a
android/src/com/owncloud/android/ui/dialog/ChangelogDialog.java
Line 36 in 14a2b28
android/src/com/owncloud/android/ui/dialog/UploadSourceDialogFragment.java
Line 43 in 988375a
android/src/com/owncloud/android/ui/dialog/SslValidatorDialog.java
Line 53 in 988375a
android/src/com/owncloud/android/files/services/FileUploader.java
Lines 193 to 195 in f3f52a8
android/src/com/owncloud/android/files/services/OnUploadCompletedListener.java
Line 23 in 988375a
This class seems important, however it's not in use:
android/src/com/owncloud/android/services/observer/RecursiveFolderObserver.java
Line 30 in 0cb666d
android/src/com/owncloud/android/ui/adapter/GroupAdapter.java
Lines 21 to 33 in 988375a
android/src/com/owncloud/android/ui/adapter/LogListAdapter.java
Lines 21 to 74 in 988375a
These two classes seem to not be used anymore, so both, and the package thire in can be removed:
android/src/com/owncloud/android/ui/dialog/parcel/MenuParcelable.java
Lines 21 to 51 in ee85bf9
android/src/com/owncloud/android/ui/dialog/parcel/MenuItemParcelable.java
Lines 21 to 61 in a46eb27
Lol
android/src/com/owncloud/android/ui/fragment/AuthenticatorAccountDetailsFragment.java
Lines 21 to 27 in 988375a
android/src/com/owncloud/android/ui/QuickAction.java
Lines 67 to 90 in 988375a
lol nr. 2
android/src/com/owncloud/android/ui/fragment/AuthenticatorGetStartedFragment.java
Lines 21 to 27 in 988375a
android/src/com/owncloud/android/utils/DialogMenuItem.java
Lines 21 to 247 in 988375a
android/src/com/owncloud/android/utils/UploadUtils.java
Lines 21 to 53 in 988375a
android/src/com/owncloud/android/ui/RadioButtonPreference.java
Lines 21 to 39 in 988375a
Methods not in use anymore
android/src/com/owncloud/android/authentication/AccountAuthenticator.java
Lines 322 to 339 in 292feb1
android/src/com/owncloud/android/ui/adapter/DiskLruImageCache.java
Lines 144 to 173 in 988375a
android/src/com/owncloud/android/broadcastreceivers/ConnectivityActionReceiver.java
Lines 202 to 226 in 0ad8492
android/src/com/owncloud/android/features/FeatureList.java
Lines 89 to 91 in 1b482c3
android/src/com/owncloud/android/services/OperationsService.java
Lines 778 to 788 in ceb1265
android/src/com/owncloud/android/ui/activity/Preferences.java
Lines 762 to 764 in f89195b
Things to REFACTOR
android/src/com/owncloud/android/datamodel/FileDataStorageManager.java
Lines 1087 to 1096 in 4a1ce06
android/src/com/owncloud/android/datamodel/ThumbnailsCacheManager.java
Lines 611 to 647 in 7748321
android/src/com/owncloud/android/media/MediaControlView.java
Lines 93 to 193 in 988375a
android/src/com/owncloud/android/providers/FileContentProvider.java
Lines 253 to 303 in fa4b5bc
android/src/com/owncloud/android/ui/dialog/ConflictsResolveDialog.java
Lines 42 to 47 in 3ba849d
https://github.com/owncloud/android/blob/426bfefe9db7f1ad4aea47a03cc1009bf1e2323e/src/com/owncloud/android/ui/errorhandling/ErrorMessageAdapter.java#L21-L481
findActionById()
calls orfinal
object declarationsandroid/src/com/owncloud/android/ui/fragment/PublicShareDialogFragment.java
Lines 742 to 824 in c41092a
android/src/com/owncloud/android/ui/notifications/NotificationUtils.java
Lines 21 to 74 in 7132c10
android/src/com/owncloud/android/ui/preview/PreviewImagePagerAdapter.java
Lines 245 to 395 in 9b40319
android/src/com/owncloud/android/ui/preview/PreviewVideoErrorAdapter.java
Lines 51 to 78 in e02c685
android/src/com/owncloud/android/ui/preview/PreviewVideoFragment.java
Lines 603 to 606 in a194762
android/src/com/owncloud/android/ui/whatsnew/ProgressIndicator.java
Line 38 in 1b482c3
android/src/com/owncloud/android/ui/SquareImageView.java
Line 26 in 988375a
android/src/com/owncloud/android/utils/BitmapUtils.java
Lines 138 to 174 in a0d3714
android/src/com/owncloud/android/utils/PowerUtils.java
Lines 20 to 34 in 9d3d42d
android/src/com/owncloud/android/widgets/ActionEditText.java
Line 38 in 988375a
https://github.com/owncloud/android-library/blob/11363adedb00211c321ba7ed2db8dd1fcc2421c9/src/com/owncloud/android/lib/common/network/AdvancedSslSocketFactory.java#L158-L162
https://github.com/owncloud/android-library/blob/ee726119cb21ac07c17857cb1a81baa262bf42da/src/com/owncloud/android/lib/resources/shares/ShareXMLParser.java#L296-L369
android/src/com/owncloud/android/ui/activity/HookActivity.java
Lines 21 to 26 in 988375a
Need despaget
The text was updated successfully, but these errors were encountered: