remove unused classes #2178
remove unused classes #2178
Conversation
| @@ -1879,9 +1879,6 @@ private void showUntrustedCertDialog(RemoteOperationResult result) { | |||
|
|
|||
| } | |||
|
|
|||
| /** | |||
| * Called from SslValidatorDialog when a new server certificate was correctly saved. | |||
There was a problem hiding this comment.
Is this method being used now that SslValidatorDialog has been also deleted?
| @@ -1879,9 +1879,6 @@ private void showUntrustedCertDialog(RemoteOperationResult result) { | |||
|
|
|||
| } | |||
There was a problem hiding this comment.
Update the year and include your name as @author at the top of the class
| /** | ||
| * Called from SslValidatorDialog when a new server certificate could not be saved | ||
| * when the user requested it. | ||
| */ | ||
| @Override | ||
| public void onFailedSavingCertificate() { |
There was a problem hiding this comment.
And this method? Is being used?
There was a problem hiding this comment.
yes, this is also an override. Overides should not be removed even if they are not used.
I've updated the issue because of that.
There was a problem hiding this comment.
Yes, you're right, I didn't see the Override label
| @@ -1,39 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
This class was included in methods to delete in #2153, I've just moved it to classes to delete and checked it as done.
|
Code approved, no QA needed in my opinion since we are deleting non-used classes, what do you think @jesmrec? |
|
Only assuring that the app is not losing the basic functionality, only smoke testing. Checks to perform:
All OK. Approved |
remove unused radiobuttonpref. class remove navigation drawer item update copyright and author
remove classes listed in #2153