Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New arch] Refactor AuthenticatorActivity #2808

Closed
22 tasks done
abelgardep opened this issue Feb 5, 2020 · 0 comments · Fixed by #2826
Closed
22 tasks done

[New arch] Refactor AuthenticatorActivity #2808

abelgardep opened this issue Feb 5, 2020 · 0 comments · Fixed by #2826
Assignees
@abelgardep
Labels
Estimation - 8 (XL) New architecture
Milestone
2.15

Comments

@abelgardep
Copy link
Contributor

abelgardep commented Feb 5, 2020 •
edited by davigonz
Loading

AuthenticatorActivity handles UX, network operations, account creation etc..

The main idea is to reduce AuthenticatorActivity responsabilities using usecases created in #2634

TASKS

  • Research (if needed)
  • Create branch new_arch/2808-Refactor_AuthenticationActivity
  • Development tasks
    • Convert AuthenticatorActivity from Java to Kotlin
    • Create AuthenticatorViewModel
    • Handle UnsignedCertificate error
    • Fix glitch not showing icons on landscape
    • Call GetServerInfo from viewmodel and handle error
    • Remove AuthenticateAsyncTask
    • Remove callbacks
    • Remove GetServerInfoOperation (Logic moved to ServerRepository)
    • Remove GetAuthenticationMethodsOperation (Logic moved to ServerRepository)
    • Remove GetServerInfoOperation from OperationsService
    • Login using usecase
    • Error handling
    • Handle rotation changes
    • Add UI tests (LoginActivity)
    • Add Unit tests (OCAuthenticationViewModel)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch new_arch/2808-Refactor_AuthenticationActivity into master

Questions

  • Should we remove landscape mode from login? This would reduce logic and test cases.

PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abelgardep abelgardep

Labels
Estimation - 8 (XL) New architecture
Projects
None yet
Milestone
2.15
Development

Successfully merging a pull request may close this issue.

[New arch] Complete login owncloud/android
3 participants
@jesmrec @davigonz @abelgardep