-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New arch] Complete login #2826
Conversation
6f3f964
to
a001db5
Compare
a15fa0a
to
ce3acff
Compare
…was being used, e.g. reauthentication after authorization expiration [WIP]
(7) [FIXED]
Current: account with new user is created Android 10 |
(8) [FIXED]About redirections
Current: error: I guess the problem is in the GET request just after clicking "Log in". This is the sent request:
and this is the one sent in stable
Android 10 |
(9) [FIXED]Following (8) With an URL with 302 redirection and performing the same steps, login is not posible either. Error message: The problem might be the same as (8), but checking the requests flow, i did not see any Android 10 |
About this, previous behaviour shows message from response body directly |
Sure Tasks to solve this:
|
We receive a ResultCode.WRONG_CONNECTION at RemoteOperationHandler, any idea @davigonz ? |
Related with #2826 (comment) We are not checking ResultCode.SERVICE_UNAVAILABLE (503 Service Unavailable) at ThrowableExt, this is the resultCode we receive when server is under maintenance. We could show something like "Service currently not available" or similar in that case. @davigonz @jesmrec |
Let's keep it with the same behaviour we had before, i.e. showing the response body message. |
(10) [FIXED]
Current: crash appears Android 10 |
Changes applied, @jesmrec. Ready to test again 👍 |
Most of the reports are fixed, but a couple of glitches: (3)Problem is fixed, message is correct after denying the certificate. But, the icon in the status message is he following one: is that correct? in (7)Performing the steps, the functional behaviour is correct, but, a blank space appears between the URL and the status message: |
both (3) and (7) fixed, let's start the 2nd round |
Everything finished, completed and fixed. This is approved on my side. |
Implements:
Needs owncloud/android-library#309
Improvements
We have replaced old png icons with vectored ones
We have included an assert to check connectivity before calling a network operation in viewModels (included in new architecture).
Uses that require connection until this PR:
Included in this PR:
QA
Test plan:
https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.15/2826-Authentication.md
BUGS & IMPROVEMENTS