[FEATURE REQUEST] [oCIS] Respect Capability "privateLinks": false

[michaelstingl]

Is your feature request related to a problem? Please describe.

oCIS doesn't have the oC10-style private links. It's also announced as false in the capabilities:

% cat ocis.capabilities | jq .ocs.data.capabilities.files
{
  "privateLinks": false,
  "bigfilechunking": false,
  "undelete": true,
  "versioning": true,
  "favorites": false,
  "blacklisted_files": [],
  "tus_support": {
    "version": "1.0.0",
    "resumable": "1.0.0",
    "extension": "creation,creation-with-upload",
    "max_chunk_size": 100000000,
    "http_method_override": ""
  },
  "archivers": [
    {
      "enabled": true,
      "version": "2.0.0",
      "formats": [
        "tar",
        "zip"
      ],
      "archiver_url": "/archiver",
      "max_num_files": "10000",
      "max_size": "1073741824"
    }
  ],
  "app_providers": [
    {
      "enabled": true,
      "version": "1.0.0",
      "apps_url": "/app/list",
      "open_url": "/app/open",
      "new_url": "/app/new"
    }
  ]
}

Describe the solution you'd like

Android app should respect the capability, and hide the private link entries on all screens.

Additional context

Desktop issues:

• [oCIS] Respect Capability "privateLinks": false client#9573
• Desktop client should respect "privateLinks":false from capabilities client#8998

iOS issue:

• [FEATURE REQUEST] [oCIS] Respect Capability "privateLinks": false ios-app#1138

TASKS

• Research (if needed)
• Create branch feature/private_link_capability
• Development tasks
  • Add a new field in capabilities response
  • Add a new field in capabilities domain model
  • Add a new field in capabilities entity
  • Show or hide the private link button when sharing depending on the capability
• Code review and apply changes requested
• Design test plan
• QA
• Merge branch feature/private_link_capability into master

PR

• App [Feature] Respect private link capability #3738
• Library (if needed) [Feature] Respect private link capability android-library#505

[jesmrec]

Silly question came to my mind: private link means link like http://<url>/f/<file-id> , right?

Not the internal sharing with other users (sometimes also called private sharing)

[michaelstingl]

Silly question came to my mind: private link means link like http://<url>/f/<file-id> , right?

Yes exactly. http://<url>/f/<file-id> or http://<url>/index.php/f/<file-id>

[abelgardep]

With current behavior, we don't show the private link if it is not in the files propfind.

In case the capability is false, the server shouldn't send the private link in the propfind, right?

[michaelstingl]

With current behavior, we don't show the private link if it is not in the files propfind.

In case the capability is false, the server shouldn't send the private link in the propfind, right?

Yes, oCIS doesn't include the private links in the PROPFIND response.