[Feature] Respect private link capability

[abelgardep]

Related Issues

App: #3732

Library PR (if needed): owncloud/android-library#505

• Added changelog files for the fixed issues in folder changelog/unreleased. More info here

---

QA

• (1) oC10 + capability false [Feature] Respect private link capability #3738 (comment) [FIXED]
• (2) Sharing API disabled [Feature] Respect private link capability #3738 (comment) [WONTFIX HERE]

[JuancaG05]

Great work! LGTM 👍

[jesmrec]

Three cases to check:

• privateLink: false(oCIS) -> private link not available ✅
• privateLink: true -> private link available ✅
• No privateLink in capabilities -> private link available ✅

[jesmrec]

(1) [FIXED]

Something weird. Is the platform (oCIS/oC10) involved in the logic?

in oCIS: "privateLinks": false -> no private link
in oC10: "privateLinks": false -> private link available.

Samsung A51 Android12
a745542e4

[jesmrec]

(2) [WONT FIX HERE]

This case is also interesting to take in account:

1. In server admin dashboard, open Admin -> Sharing
2. Disable Allow apps to use the Share API

in that case, Share API is not available and users will not be allowed to shares with users or by link. But, the "Share" option is still available because the private link.

I mean, if:

• Share API is disabled
• privateLinks: false

the sharing option in top bar could be disabled as well.

This is an improvement, not a bad behaviour

Samsung A51 Android12
a745542e4

[abelgardep]

@jesmrec
(1) Should be fixed now.
(2) It's not that simple to implement at the moment. I think we can create a new issue to do that

[jesmrec]

@abelgardep after fixing (1), if privateLink capability is not retrieved, private links are not available.

[jesmrec]

(1) fixed
(2) addressed to #3740

Feature is approved