-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Respect private link capability #3738
[Feature] Respect private link capability #3738
Conversation
636c43a
to
847369a
Compare
a506382
to
a745542
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM 👍
Three cases to check:
|
(1) [FIXED]Something weird. Is the platform (oCIS/oC10) involved in the logic? in oCIS: Samsung A51 Android12 |
(2) [WONT FIX HERE]This case is also interesting to take in account:
in that case, Share API is not available and users will not be allowed to shares with users or by link. But, the "Share" option is still available because the private link. I mean, if:
the sharing option in top bar could be disabled as well. This is an improvement, not a bad behaviour Samsung A51 Android12 |
@jesmrec |
@abelgardep after fixing (1), if |
(1) fixed Feature is approved |
Related Issues
App: #3732
Library PR (if needed): owncloud/android-library#505
QA