[New architecture] Whole flow tests for sharing #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davigonz
changed the title
9 tasks
…ithAlreadyExistingShares tests
davigonz
force-pushed
the
new_arch/flow_sharing_tests
branch
from
4dc4d9f
to
c4becd4
Compare
[New architecture] Improve viewmodel behaviour
3 tasks
jesmrec
reviewed
Jun 12, 2019
...oudApp/src/androidTest/java/com/owncloud/android/shares/ui/usecases/CreatePublicShareTest.kt
Show resolved
Hide resolved
...oudApp/src/androidTest/java/com/owncloud/android/shares/ui/usecases/DeletePublicShareTest.kt
Show resolved
Hide resolved
|
Added a couple of tiny comments regarding the tests. Tests are OK, but some refactor is needed in the additional methods (get files for sharing, account managing...). I will create another issue to keep utils for testing together, avoiding repeated code. |
owncloudApp/src/main/java/com/owncloud/android/capabilities/viewmodel/OCCapabilityViewModel.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java
Show resolved
Hide resolved
|
@jesmrec code approved, ready to test |
…achable inside the fragment, for folders public share dialog
|
Added a small tweak (an Apart of that, approved on my side. |
jesmrec
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2531