Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [New arch] Crash when removing account #3725

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

JuancaG05
Copy link
Collaborator

Related Issues

App: #3721


QA

@JuancaG05 JuancaG05 self-assigned this Aug 5, 2022
@JuancaG05 JuancaG05 linked an issue Aug 5, 2022 that may be closed by this pull request
@jesmrec
Copy link
Collaborator

jesmrec commented Aug 8, 2022

Crash is fixed. But, every time one account is removed, the following trace is generated. Could it be "dangerous"?:

2022-08-08 14:07:01.516 16512-16512/com.owncloud.android.debug D/StrictMode: StrictMode policy violation: android.os.strictmode.NonSdkApiUsedViolation: Landroid/view/ViewGroup;->makeOptionalFitsSystemWindows()V
        at android.os.StrictMode.lambda$static$1(StrictMode.java:420)
        at android.os.StrictMode$$ExternalSyntheticLambda3.accept(Unknown Source:2)
        at java.lang.Class.getDeclaredMethodInternal(Native Method)
        at java.lang.Class.getPublicMethodRecursive(Class.java:2110)
        at java.lang.Class.getMethod(Class.java:2097)
        at java.lang.Class.getMethod(Class.java:1724)
        at androidx.appcompat.widget.ViewUtils.makeOptionalFitsSystemWindows(ViewUtils.java:84)
        at androidx.appcompat.app.AppCompatDelegateImpl.createSubDecor(AppCompatDelegateImpl.java:982)
        at androidx.appcompat.app.AppCompatDelegateImpl.ensureSubDecor(AppCompatDelegateImpl.java:815)
        at androidx.appcompat.app.AppCompatDelegateImpl.setContentView(AppCompatDelegateImpl.java:703)
        at androidx.appcompat.app.AppCompatDialog.setContentView(AppCompatDialog.java:95)
        at androidx.appcompat.app.AlertController.installContent(AlertController.java:232)
        at androidx.appcompat.app.AlertDialog.onCreate(AlertDialog.java:279)
        at android.app.Dialog.dispatchOnCreate(Dialog.java:432)
        at android.app.Dialog.show(Dialog.java:321)
        at androidx.fragment.app.DialogFragment.onStart(DialogFragment.java:710)
        at androidx.fragment.app.Fragment.performStart(Fragment.java:3053)
        at androidx.fragment.app.FragmentStateManager.start(FragmentStateManager.java:587)
        at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:279)
        at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1840)
        at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1764)
        at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1701)
        at androidx.fragment.app.FragmentManager$4.run(FragmentManager.java:488)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7870)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

@JuancaG05
Copy link
Collaborator Author

@jesmrec I was researching a bit and seems that StrictMode is a debugging tool used to detect likely accidental accesses to disk or network, so in the same line as LeakCanary. For the moment it shouldn't suppose any problem. More info: https://developer.android.com/reference/kotlin/android/os/StrictMode

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 9, 2022

Let's move forward this, then

@JuancaG05 JuancaG05 force-pushed the new_arch/fix_removing_account branch from 9dd3243 to 9298d8f Compare August 16, 2022 16:30
@JuancaG05 JuancaG05 merged commit e9b7e24 into new_arch/synchronization Aug 17, 2022
@JuancaG05 JuancaG05 deleted the new_arch/fix_removing_account branch August 17, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [New arch] Crash when removing account
3 participants