Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Arch] Uploads open document #3757

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

abelgardep
Copy link
Contributor

Uses ACTION_OPEN_DOCUMENT instead of ACTION_GET_CONTENT to open the file picker from the floating action button.

It should retain the access for enough time so we have time to upload the file.

Should fix some reports we have in #2818 where we lose access to the file


QA

@abelgardep abelgardep self-assigned this Sep 15, 2022
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 20, 2022

Reports fixed from uploads: #2818 (comment)

(2)
(4)
(15)
(17)

Report (8) with same behaviour (is this intended to be fixed here)? i guess not, just to be sure.

@abelgardep
Copy link
Contributor Author

Report (8) with same behaviour (is this intended to be fixed here)? i guess not, just to be sure.

Nothing to do with chunking in this PR. 👍

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 20, 2022

Go ahead with this. If new stuff happens, we can handle in a different PR

@abelgardep abelgardep merged commit a6b0dd0 into new_arch/synchronization Sep 21, 2022
@abelgardep abelgardep deleted the new_arch/uploads_open_document branch September 21, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants