Skip to content

Commit

Permalink
SyncEngine: Don't duplicate fatal errors
Browse files Browse the repository at this point in the history
Previously fatal error texts were duplicated: Once they entered the
SyncResult via the SyncFileItem and once via syncError().

syncError is intended for folder-wide sync issues that are not pinned
to particular files. Thus that duplicated path is removed.

For #5088
  • Loading branch information
ckamm committed Jul 31, 2019
1 parent 23f005e commit b3a3f17
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/libsync/syncengine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -759,10 +759,6 @@ void SyncEngine::slotItemCompleted(const SyncFileItemPtr &item)
{
_progressInfo->setProgressComplete(*item);

if (item->_status == SyncFileItem::FatalError) {
syncError(item->_errorString);
}

emit transmissionProgress(*_progressInfo);
emit itemCompleted(item);
}
Expand Down

0 comments on commit b3a3f17

Please sign in to comment.