Prevent implementations of Result<bool,..>

owncloud · Jun 28, 2021 · f5f0675 · f5f0675
1 parent 3fd7001
commit f5f0675
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/common/result.h b/src/common/result.h
@@ -35,6 +35,7 @@ class Result
         : _result(std::move(value))
         , _isError(false)
     {
+        static_assert(!std::is_same<T, bool>::value, "Bool is not supported as this class overrides the bool operator");
     }
     // TODO: This doesn't work if T and Error are too similar
     Result(Error error)

diff --git a/src/common/vfs.cpp b/src/common/vfs.cpp
@@ -63,7 +63,7 @@ Optional<Vfs::Mode> Vfs::modeFromString(const QString &str)
     return {};
 }
 
-Result<bool, QString> Vfs::checkAvailability(const QString &path)
+Result<void, QString> Vfs::checkAvailability(const QString &path)
 {
 #ifdef Q_OS_WIN
     const auto mode = bestAvailableVfsMode();
@@ -84,7 +84,7 @@ Result<bool, QString> Vfs::checkAvailability(const QString &path)
 #else
     Q_UNUSED(path);
 #endif
-    return true;
+    return {};
 }
 
 void Vfs::start(const VfsSetupParams &params)

diff --git a/src/common/vfs.h b/src/common/vfs.h
@@ -100,7 +100,7 @@ class OCSYNC_EXPORT Vfs : public QObject
     static QString modeToString(Mode mode);
     static Optional<Mode> modeFromString(const QString &str);
 
-    static Result<bool, QString> checkAvailability(const QString &path);
+    static Result<void, QString> checkAvailability(const QString &path);
 
     enum class AvailabilityError
     {