Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dark mode feature on Windows #11275

Closed
2 tasks done
ndekross opened this issue Oct 10, 2023 · 4 comments · Fixed by #11286
Closed
2 tasks done

Support for dark mode feature on Windows #11275

ndekross opened this issue Oct 10, 2023 · 4 comments · Fixed by #11286
Labels
Highlight p3-medium Normal priority
Milestone

Comments

@ndekross
Copy link

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Feature description

Could you kindly consider adding support for dark mode on Windows 11? It's currently the only application I use that lacks this feature, making it quite glaring during nighttime usage.

Proposed solution

In the "Settings" tab, under "General Settings," there could be a new dropdown menu labeled "Appearance." Users would have the option to select from three modes: Light, Dark, or System, with System being the default selection. The System setting would allow the app to mirror the overall operating system's theme. Conversely, selecting either Dark or Light would override the system setting.

Alternative solutions you considered

No response

Additional context

No response

@TheOneRing
Copy link
Member

Since we plan to use Qt6.5+ with the 6.0 client this should be possible.

@TheOneRing TheOneRing added this to the Desktop 6.0 milestone Oct 10, 2023
@TheOneRing
Copy link
Member

TheOneRing commented Oct 11, 2023

Windows theme always picks the light theme: https://www.qt.io/blog/dark-mode-on-windows-11-with-qt-6.5

Win Theme (Win Vista Aero) Fusion theme:
image image

@michaelstingl should we add a style picker so people can choose?

@michaelstingl
Copy link
Contributor

Fusion theme:

6.0 should switch to Fusion, no config UI needed.

@saw-jan
Copy link
Member

saw-jan commented Nov 2, 2023

Tested on ownCloud 6.0.0.12536-daily20231102 1ed7c6
Screenshot from 2023-11-02 16-46-08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Highlight p3-medium Normal priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants