Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folderwatcher access to Application::_instance before initialisation #11460

Closed
sentry-io bot opened this issue Jan 5, 2024 · 2 comments · Fixed by #11475
Closed

Folderwatcher access to Application::_instance before initialisation #11460

sentry-io bot opened this issue Jan 5, 2024 · 2 comments · Fixed by #11475
Assignees
@erikjv
Labels
p2-high Escalation, on top of current planning, release blocker type:bug
Milestone
Desktop 6.0

Comments

@sentry-io
Copy link

sentry-io bot commented Jan 5, 2024

Sentry Issue: DESKTOP-WIN-AND-MAC-EVM

SIGABRT / 0xfffffffa / 0x3e80001743c: Fatal Error: SIGABRT / 0xfffffffa / 0x3e80001743c
  File "pthread_kill.c", line 44, in __pthread_kill_implementation
  File "pthread_kill.c", line 78, in __pthread_kill_internal
  File "pthread_kill.c", line 89, in pthread_kill
  File "malloc.c", line 3391, in __libc_free
  File "qobject.cpp", line 140, in QObjectData::~QObjectData
@sentry-io sentry-io bot added type:bug p2-high Escalation, on top of current planning, release blocker labels Jan 5, 2024
@TheOneRing TheOneRing added this to the Desktop 6.0 milestone Jan 5, 2024
@sentry-io Sentry.io
Copy link
Author

sentry-io bot commented Jan 9, 2024

Sentry issue: DESKTOP-WIN-AND-MAC-EZV

@TheOneRing TheOneRing changed the title __pthread_kill_implementation Folderwatcher access to Application::_instance before initialisation Jan 9, 2024
@erikjv erikjv self-assigned this Jan 12, 2024
@erikjv erikjv linked a pull request Jan 16, 2024 that will close this issue
Fix early-use crash in folder watcher on Linux #11475
Merged
erikjv added a commit that referenced this issue Jan 16, 2024
@erikjv
Fix early-use crash in folder watcher on Linux
f32f86d 
In a few error scenarios (out-of-memory or out-of-space), the folder
watcher on Linux shows a dialog with an error message. If this occurs
during start-up before the GUI is initialised, this will lead to a
crash.

This is fixed by delaying the VFS start until after event loop is
started, guaranteeing that the GUI is up and running.

Fixes: #11460
@erikjv erikjv mentioned this issue Jan 16, 2024
Merged
erikjv added a commit that referenced this issue Jan 17, 2024
@erikjv
Fix early-use crash in folder watcher on Linux
9f054fe 
In a few error scenarios (out-of-memory or out-of-space), the folder
watcher on Linux shows a dialog with an error message. If this occurs
during start-up before the GUI is initialised, this will lead to a
crash.

This is fixed by delaying the VFS start until after event loop is
started, guaranteeing that the GUI is up and running.

Fixes: #11460
TheOneRing pushed a commit that referenced this issue Jan 17, 2024
@erikjv @TheOneRing
Fix early-use crash in folder watcher on Linux
82c7a2e 
In a few error scenarios (out-of-memory or out-of-space), the folder
watcher on Linux shows a dialog with an error message. If this occurs
during start-up before the GUI is initialised, this will lead to a
crash.

This is fixed by delaying the VFS start until after event loop is
started, guaranteeing that the GUI is up and running.

Fixes: #11460
@saw-jan
Copy link
Member

saw-jan commented Jan 22, 2024

How can we confirm the fix here?
CC @TheOneRing

TheOneRing pushed a commit that referenced this issue May 22, 2024
@erikjv @TheOneRing
Fix early-use crash in folder watcher on Linux
628793a 
In a few error scenarios (out-of-memory or out-of-space), the folder
watcher on Linux shows a dialog with an error message. If this occurs
during start-up before the GUI is initialised, this will lead to a
crash.

This is fixed by delaying the VFS start until after event loop is
started, guaranteeing that the GUI is up and running.

Fixes: #11460
(cherry picked from commit 82c7a2e)
TheOneRing pushed a commit that referenced this issue May 23, 2024
@erikjv @TheOneRing
Fix early-use crash in folder watcher on Linux
1f18ee6 
In a few error scenarios (out-of-memory or out-of-space), the folder
watcher on Linux shows a dialog with an error message. If this occurs
during start-up before the GUI is initialised, this will lead to a
crash.

This is fixed by delaying the VFS start until after event loop is
started, guaranteeing that the GUI is up and running.

Fixes: #11460
(cherry picked from commit 82c7a2e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
p2-high Escalation, on top of current planning, release blocker type:bug
Projects
None yet
Milestone
Desktop 6.0
Development

Successfully merging a pull request may close this issue.

Fix early-use crash in folder watcher on Linux owncloud/client
3 participants
@erikjv @TheOneRing @saw-jan