-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use credentials manager for prox credentials #261
Comments
|
As requested at other places, this should be able to store credentials for multiple proxies as users might be in different environments and don't want to retype their credentials. |
The proxyAuthenticationRequired() signal now goes to the ProxyAuthHandler class. That class will try to read the proxy settings from the keychain or ask the user about them. We won't ask the user for credentials for explicitly configured proxies. It also does not change how the credentials for explicitly configured proxies are stored. (see #261)
As of 2124098 we now store proxy passwords using "hostname:port" as key. But only for credentials that are entered in a special dialog when using the system proxy. The explicitly configured proxy still stores the credentials the same way as before. I think we could either remove the proxy auth config from the network options altogether, or change how storage is done. |
We can discuss removal of credentials for manual specified proxies. |
It appears we already use qtkeychain https://github.com/owncloud/client/blob/master/src/gui/proxyauthhandler.cpp |
Is there any way to confirm this? Or move it to Done? |
Ideally we would have a proxy that requires credentials around. |
Keychain
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: