-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selective sync may not locally remove unneeded files #5783
Comments
Test case in TestSyncEngine::testSelectiveSyncBug : parentFolder/subFolder/fileA.txt should be deleted but it is not. |
ogoffart
added a commit
that referenced
this issue
Jun 6, 2017
…spite other modified files Issue #5783 When the directry that should be removed by selective sync contains changes, we ignore the whole sub tree instead of only ignoreing new files. We cannot ignore the whole directory, we need to ignore only the directory that do not have files to remove
ogoffart
added a commit
that referenced
this issue
Jun 7, 2017
…spite other modified files Issue #5783 When the directry that should be removed by selective sync contains changes, we ignore the whole sub tree instead of only ignoreing new files. We cannot ignore the whole directory, we need to ignore only the directory that do not have files to remove
ogoffart
added a commit
that referenced
this issue
Jun 8, 2017
…spite other modified files Issue #5783 When the directry that should be removed by selective sync contains changes, we ignore the whole sub tree instead of only ignoreing new files. We cannot ignore the whole directory, we need to ignore only the directory that do not have files to remove
I've tested it using the test case from the initial comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a folder is removed from the sync by deselecting it in the selective sync ui, typically it is deleted locally. However, when there are new, conflicting or untracked files inside the folder, nothing at all is done with it. Discussions with @ogoffart suggest that removing all subitems that are safe to remove may be more desirable.
Steps to reproduce:
foo/
containingfoo/uptodate
,foo/subfolder/uptodate
.foo/newfile
foo/
Expected:
foo/uptodate
,foo/subfolder/uptodate
andfoo/subfolder
should be removedActual: Nothing is removed
This behavior is the result of
checkForPermission()
: All subitems inside a selective-sync ignored folder get set toIGNORED
. But even if they weren't: as long as the parent isIGNORED
subjobs are not executed inPropagateDirectory
.The text was updated successfully, but these errors were encountered: