Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Windows VFS tries to hydrate excluded filenames and fails #8216

Closed
jnweiger opened this issue Nov 9, 2020 · 2 comments · Fixed by #11222
Closed

[QA] Windows VFS tries to hydrate excluded filenames and fails #8216

jnweiger opened this issue Nov 9, 2020 · 2 comments · Fixed by #11222
Labels
p4-low Low priority
Milestone

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Nov 9, 2020

Seen with ownCloud client 2.7.0 RC3 on windows 10 using VFS.

  • With the web UI on the server create a folder 'Music', with a few files in them. (PNG files in my case)
  • wait until sync finishes.
  • Make sure the status column of the folder shows a cloud. If needed click and and choose 'Free up space'
  • on the client rename the folder to one of the excluded filenames. e.g. Music~
  • the folder gets removed from the server. BAD. The contents is lost now. See [QA] renaming a dehydrated folder to an excluded name leads to data loss #8217
  • enter the folder, click open a file.

Windows tries to connect the owncloud client for the contents of the file and fails after a timeout:

image
image

Expected behaviour: an excluded file should always be exclude in fully hydrated state only. (Or alternatively, the exculded files list is not applied for renames. )
The file is always available locally.

@jnweiger
Copy link
Contributor Author

jnweiger commented Nov 9, 2020

logs.zip

@jnweiger jnweiger mentioned this issue Nov 9, 2020
63 tasks
@TheOneRing TheOneRing added the p2-high Escalation, on top of current planning, release blocker label Nov 10, 2020
@jnweiger jnweiger added this to the 2.7.0 milestone Nov 11, 2020
@TheOneRing TheOneRing modified the milestones: 2.7.0, 2.8.0 Mar 17, 2021
@TheOneRing TheOneRing modified the milestones: 2.9.0, 2.10.0 Aug 6, 2021
@TheOneRing TheOneRing modified the milestones: 3.0, 4.0 May 19, 2022
@TheOneRing TheOneRing added p3-medium Normal priority and removed p2-high Escalation, on top of current planning, release blocker labels Jan 19, 2023
@TheOneRing TheOneRing added p4-low Low priority and removed p3-medium Normal priority labels Jan 26, 2023
@TheOneRing TheOneRing modified the milestones: 4.0, 5.0 Jan 26, 2023
@erikjv erikjv self-assigned this May 5, 2023
@fmoc fmoc unassigned erikjv Jun 2, 2023
@fmoc fmoc added the Needs info label Jun 2, 2023
@fmoc fmoc modified the milestones: Desktop Client 5.0, inbox Jun 2, 2023
@TheOneRing TheOneRing modified the milestones: Inbox, Desktop 6.0 Aug 31, 2023
@TheOneRing
Copy link
Member

After the rename to the excluded pattern the the files are removed from the sync set, meaning they are deleted on the server and the placholders are invalid.
TODO:

  • Improve the error message.
  • Add documentation

@TheOneRing TheOneRing modified the milestones: Desktop 6.0, Desktop 5.0 Sep 21, 2023
TheOneRing added a commit that referenced this issue Sep 21, 2023
@TheOneRing TheOneRing linked a pull request Sep 21, 2023 that will close this issue
TheOneRing added a commit that referenced this issue Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-low Low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants