Using the language selector to select an RTL language on mac does not cause the ui to be reversed

[TheOneRing]

[TheOneRing]

Maybe because we call the translations code AFTER we initialized QApplication?

[fmoc]

I think we just need to call setLayoutDirection in setupTranslations, once we can tell whether we have an RTL language or not. https://doc.qt.io/qt-5/qguiapplication.html#layoutDirection-prop

[fmoc]

I cannot reproduce this issue. You didn't reveal which locale you were testing against. I selected a random right-to-left-looking language, and without a code change the layout was changed:

I can also control the layout direction using setLayoutDirection. We could add the following snippet to setupTranslations nevertheless, if you want to:

            // use a right-to-left layout for such languages
            QApplication::setLayoutDirection(QLocale(lang).textDirection());

[TheOneRing]

I don't think we should call it directly this should be handled by the translations system.
The issue seems to only occur on mac.
I could imagin it being caused by us setting up the translations in the QApplication constructor....
@erikjv

[erikjv]

Hmm, Qt has this in QGuiApplicationPrivate::init():

    if (layout_direction == Qt::LayoutDirectionAuto || force_reverse)
        QGuiApplication::setLayoutDirection(qt_detectRTLLanguage() ? Qt::RightToLeft : Qt::LeftToRight);

That in turn is called from the QApplication constructor.

That said, I assume you're not running with the -reverse cmdline option, right? And your translations have the following translated:

        (QGuiApplication::tr("QT_LAYOUT_DIRECTION",
                         "Translate this string to the string 'LTR' in left-to-right"
                         " languages or to 'RTL' in right-to-left languages (such as Hebrew"
                         " and Arabic) to get proper widget layout.") == QLatin1String("RTL"));

Correct?

[TheOneRing]

Hmm, Qt has this in QGuiApplicationPrivate::init():

    if (layout_direction == Qt::LayoutDirectionAuto || force_reverse)
        QGuiApplication::setLayoutDirection(qt_detectRTLLanguage() ? Qt::RightToLeft : Qt::LeftToRight);

That in turn is called from the QApplication constructor.

That said, I assume you're not running with the -reverse cmdline option, right? And your translations have the following translated:

of course

        (QGuiApplication::tr("QT_LAYOUT_DIRECTION",
                         "Translate this string to the string 'LTR' in left-to-right"
                         " languages or to 'RTL' in right-to-left languages (such as Hebrew"
                         " and Arabic) to get proper widget layout.") == QLatin1String("RTL"));

Correct?

the translation is properly rtl displayed on windows and linux.
but we do argument parsing and translation setup in the constructor of QApplictation....

[github-actions]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

[gabi18]

confirmed fixed with testpilotcloud 2.9.1rc1

[gabi18]

Remaining issue with systray and dot menu?