Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Folder without subfolder show the arrow icon #8935

Closed
swoichha opened this issue Aug 24, 2021 · 3 comments · Fixed by #11524 or #11917
Closed

[QA] Folder without subfolder show the arrow icon #8935

swoichha opened this issue Aug 24, 2021 · 3 comments · Fixed by #11524 or #11917
Assignees
Milestone

Comments

@swoichha
Copy link
Contributor

Seen with client 2.9.0-beta2 on Windows 10 (Enterprise Evaluation) version 21H1 (OS build 19043.1165)

  • Start to setup the oC Desktop app
  • Fill in server, user and password
  • In the new window select "Synchronize everything from server" and select/unselect different kinds of folder with and without sub-folder. Wait until everything is sync.

Actual

  • Click on a folder with and without sub-folder the arrows is displayed.
  • When minimizing the directory tree and opening the it again, the arrow for folder without sub-folder disappears.

Expected

  • Folder without sub-folder should not have arrows.
@saw-jan
Copy link
Member

saw-jan commented Mar 28, 2024

Tested on ownCloud 6.0.0.13589-daily20240328 [32670a]

Expectation: arrow should disappear from empty folder ❓

Screenshot from 2024-03-28 15-08-01

@TheOneRing the expectation in this issue does not met. Will there be a fix to meet the expectation or arrow in the empty folders are expected (arrow will not disappear)?

@TheOneRing TheOneRing modified the milestones: Backlog, Desktop 6.0 Apr 2, 2024
@TheOneRing TheOneRing reopened this Apr 2, 2024
@erikjv
Copy link
Collaborator

erikjv commented Aug 5, 2024

The problem is that we do a propfind for only the current level. So in the example above, "myfold" is initially not expanded. When it expands, we do a propfind, get back "empty" and "ufold", but we don't know if they have subfolders, so we show the indicator. We only know that "empty" is empty when it is expanded and the propfind returns 0 (zero) items.

I tried to do a propfind with depth 2, but that somehow fails: server replied: Bad Request.

@erikjv
Copy link
Collaborator

erikjv commented Sep 24, 2024

When he folder is expanded after pressing the arrow, and we find no children, the arrow should be removed. To do this, we have to emit a row/data changed signal and indicate that there are no children, which should make the arrow disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants