Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SslErrorDialog into Application #1

Merged
merged 1 commit into from
Oct 2, 2012

Commits on Sep 10, 2012

  1. Move SslErrorDialog into Application

    This patch makes it possible to cut out a large piece from the lib. We
    want to avoid having GUI code in the daemon. For Mirall, this is now
    handled in Application. for other clients, they can do whatever they
    want with this signal, and implement their own SSL Error handling.
    
    The patch isn't exactly a beauty queen, since it involves some
    back-and-forth between application and owncloudinfo objects, but it
    seems the only way to properly separate and abstract the UI out of
    owncloudinfo, and cuts down a huge part of the dependency chain,
    especially QWidget-based classes.
    
    I haven't been able to properly test this, but if anyone can give me a
    login to a server that has wrong or untrusted SSL certificates, I'll
    happily do it.
    
    Merge? *puppy eyes*
    sebasje committed Sep 10, 2012
    Configuration menu
    Copy the full SHA
    c24728b View commit details
    Browse the repository at this point in the history