Don't emit folder watcher changes every 1s #10825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoc
approved these changes
May 9, 2023
|
Results for GUI-tests-ocis https://drone.owncloud.com/owncloud/client/15546/6/1 💥 The GUI tests failed. GUI Logs: https://cache.owncloud.com/public/owncloud/client/15546/ocis/guiReportUpload/index.html |
TheOneRing
force-pushed
the
work/watcher
branch
2 times, most recently
from
258e636
to
82b5a1e
Compare
fmoc
suggested changes
May 31, 2023
|
@TheOneRing steps to confirm this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently gather changes for up to 1s and then handle them.
Often we then ignore them as nothing, interesting for us, changed.
This change increases the interval to 10s.
If the file changed 50 times in that interval we will now only check once instead of about 10 times.
Note: When we detect a change it does not mean instant upload, we will evaluate the file and queue it for the next sync run.
Estimated impact: Less noise in the logs, slight performance improvements.