-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crashreporter #11011
Fix crashreporter #11011
Conversation
ed2c883
to
e4ae053
Compare
Should I add a changelog entry? |
src/crashreporter/main.cpp
Outdated
@@ -24,10 +24,6 @@ | |||
|
|||
int main(int argc, char *argv[]) | |||
{ | |||
QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this related to the change? Does this really aid fixing the problem? If so, I'd like to know how (to avoid this in the future).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flags are deprecated.
I will create a follow up pr which will apply our compiler settings to the crash reporter.
If it's a fix, it probably needs one. |
Its a fix for a regression, but it also adds the (ui) crash reporter to the cmd client. |
Then I guess it needs two, because the latter is a feature addition and it's a user facing component. |
3f49e4b
to
82e145b
Compare
It was a 5.0 regression so no need to create a changelog entry for that. 3b09bbc |
Co-authored-by: Fabian Müller <80399010+fmoc@users.noreply.github.com>
This change also enables the crash reporter in the cmd client
Fixes: #10998
Issue: #8991