Fix crashreporter #11011
Fix crashreporter #11011
Conversation
TheOneRing
force-pushed
the
work/crash_report
branch
from
ed2c883
to
e4ae053
Compare
|
Should I add a changelog entry? |
src/crashreporter/main.cpp
Outdated
| @@ -24,10 +24,6 @@ | |||
|
|
|||
| int main(int argc, char *argv[]) | |||
| { | |||
| QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps, true); | |||
There was a problem hiding this comment.
Is this related to the change? Does this really aid fixing the problem? If so, I'd like to know how (to avoid this in the future).
There was a problem hiding this comment.
The flags are deprecated.
I will create a follow up pr which will apply our compiler settings to the crash reporter.
If it's a fix, it probably needs one. |
Its a fix for a regression, but it also adds the (ui) crash reporter to the cmd client. |
|
Then I guess it needs two, because the latter is a feature addition and it's a user facing component. |
TheOneRing
force-pushed
the
work/crash_report
branch
from
3f49e4b
to
82e145b
Compare
|
It was a 5.0 regression so no need to create a changelog entry for that. 3b09bbc |
Co-authored-by: Fabian Müller <80399010+fmoc@users.noreply.github.com>
This change also enables the crash reporter in the cmd client
Fixes: #10998
Issue: #8991