Handle "selected sync destination is unusable" case better in setup wizard #11029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
reviewed
Jul 12, 2023
| Default, | ||
| EvaluationFailed, | ||
| }; | ||
|
|
TheOneRing
reviewed
Jul 12, 2023
TheOneRing
reviewed
Jul 12, 2023
TheOneRing
approved these changes
Jul 21, 2023
fmoc
force-pushed
the
work/setup-wizard-error
branch
from
04641ee
to
461a326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10680.
This PR makes sure to "unhide" the advanced settings whenever the selected/default sync root is unavailable (tested with
/dev/null). It also remembers the user's last input, initializing the sync root with a default value only once, allowing users to easily edit their last value.Note: this does not, in any way, block the Finish button. We never live-check such data anywhere else (e.g., checking "can we login already", asking upon every single button press to enable the button only once it works). It's by design to run more advanced checks when the user clicks on "Next" resp. "Finish".