-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle "selected sync destination is unusable" case better in setup wizard #11029
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me 👍
Default, | ||
EvaluationFailed, | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q_ENUM...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci
04641ee
to
461a326
Compare
Fixes #10680.
This PR makes sure to "unhide" the advanced settings whenever the selected/default sync root is unavailable (tested with
/dev/null
). It also remembers the user's last input, initializing the sync root with a default value only once, allowing users to easily edit their last value.Note: this does not, in any way, block the Finish button. We never live-check such data anywhere else (e.g., checking "can we login already", asking upon every single button press to enable the button only once it works). It's by design to run more advanced checks when the user clicks on "Next" resp. "Finish".