Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip user info from URL in New Connection Wizard #11509

Merged
merged 1 commit into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/unreleased/11497
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Bugfix: strip user information from new-connection URL

Credentials in the URL are not supported for some time. This fix strips
them from the URL before storage and using it to authenticate the client
to the server.

https://github.com/owncloud/client/issues/11497
https://github.com/owncloud/client/pull/11509
2 changes: 1 addition & 1 deletion src/gui/newwizard/states/serverurlsetupwizardstate.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void ServerUrlSetupWizardState::evaluatePage()
userProvidedUrl.prepend(defaultUrlSchemeC);
}

return QUrl::fromUserInput(userProvidedUrl);
return QUrl::fromUserInput(userProvidedUrl).adjusted(QUrl::RemoveUserInfo);
}();

// (ab)use the account builder as temporary storage for the URL we are about to probe (after sanitation)
Expand Down
Loading