HttpLogger: Log redirects #11581
Merged
HttpLogger: Log redirects #11581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/log_redirect
branch
from
29263a8
to
a82ff38
Compare
TheOneRing
force-pushed
the
work/log_redirect
branch
from
a82ff38
to
5e39e15
Compare
|
@jesmrec @felix-schwarz how are redirects logged on Android and ios? |
|
straight example of redirect: |
|
Same example for the iOS app:
The iOS app also alerts the user to the redirect and asks the user to confirm it:
|
|
Thx, so it's the location header (I don't get to see it if I tell Qt to follow redirect_no_less_secure). |
erikjv
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a debugging session, I discovered that the client can send the same request multiple times if the redirect is directly handled by Qt.
This wasn't discovered previously as we disallow redirects for most requests.
{ "request": { "body": { "length": 0 }, "header": { "Accept": "*/*", "Accept-Language": "en_DE", "Authorization": "Basic [redacted]", "Original-Request-ID": "697f9664-e926-4569-be6c-5c2c228010cf", "User-Agent": "Mozilla/5.0 (Windows) mirall/6.0.0-git (ownCloud, windows-10.0.22631 ClientArchitecture: x86_64 OsArchitecture: x86_64)", "X-Request-ID": "697f9664-e926-4569-be6c-5c2c228010cf" }, "info": { "cached": false, "id": "697f9664-e926-4569-be6c-5c2c228010cf", "method": "GET", "redirects": [ "https://attic.owncloud.com/desktop/ownCloud/daily/6.0/win/ownCloud-6.0.0.12944-daily20231221.x64.msi", "https://attic.owncloud.com/desktop/ownCloud/daily/6.0/win/ownCloud-6.0.0.12944-daily20231221.x64.msi/" ], "url": "https://download.owncloud.com/desktop/ownCloud/daily/6.0/win/ownCloud-6.0.0.12944-daily20231221.x64.msi" } } }, { "response": { "body": { "length": 0 }, "header": { "Authorization": "Basic [redacted]", "Content-Type": "text/html; charset=utf-8", "Date": "Mon, 08 Apr 2024 14:59:01 GMT", "Referrer-Policy": "strict-origin-when-cross-origin", "Server": "Caddy", "Strict-Transport-Security": "max-age=315360000; preload", "Transfer-Encoding": "chunked", "X-Content-Type-Options": "nosniff", "X-Frame-Options": "SAMEORIGIN", "X-Xss-Protection": "0" }, "info": { "id": "697f9664-e926-4569-be6c-5c2c228010cf", "method": "GET", "redirects": [ "https://attic.owncloud.com/desktop/ownCloud/daily/6.0/win/ownCloud-6.0.0.12944-daily20231221.x64.msi", "https://attic.owncloud.com/desktop/ownCloud/daily/6.0/win/ownCloud-6.0.0.12944-daily20231221.x64.msi/" ], "reply": { "cached": false, "duration": 293, "durationString": "duration(0h, 0min, 0s, 293ms)", "error": "Error transferring https://attic.owncloud.com/desktop/ownCloud/daily/6.0/win/ownCloud-6.0.0.12944-daily20231221.x64.msi/ - server replied: Not Found", "status": 404, "version": "HTTP 2" }, "url": "https://download.owncloud.com/desktop/ownCloud/daily/6.0/win/ownCloud-6.0.0.12944-daily20231221.x64.msi" } } }