Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors: Include path in discovery error message #6850

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Errors: Include path in discovery error message #6850

merged 1 commit into from
Oct 29, 2018

Conversation

ckamm
Copy link
Contributor

@ckamm ckamm commented Oct 29, 2018 •
edited
Loading

For #6826

@ckamm ckamm added this to the 2.5.1 milestone Oct 29, 2018
@ckamm ckamm self-assigned this Oct 29, 2018
@ckamm ckamm requested a review from guruz October 29, 2018 11:47
@ckamm ckamm changed the title Errors: Include path in discovery error message #6826 Errors: Include path in discovery error message Oct 29, 2018
@ckamm ckamm mentioned this pull request Oct 29, 2018
Closed
ogoffart
ogoffart reviewed Oct 29, 2018
View reviewed changes
Copy link
Contributor

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the test to test that? I guess you just have to add the file name in testRemoteDiscoveryError_data in testremotediscovery.cpp

@guruz guruz merged commit 7a4792b into 2.5 Oct 29, 2018
@guruz guruz deleted the 6826-path-in-error branch October 29, 2018 18:56
@guruz
Copy link
Contributor

guruz commented Oct 29, 2018

(Feel free to push the test directly into 2.5 or master)

@ckamm
Copy link
Contributor Author

ckamm commented Nov 1, 2018

I pushed the test changes to 2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoffart ogoffart ogoffart left review comments

@guruz guruz guruz approved these changes

Assignees

@ckamm ckamm

Labels
None yet
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ckamm @guruz @ogoffart