-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't follow redirects besides in the connection validator #8253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/redirects
branch
from
November 24, 2020 14:03
56e327d
to
86d04a6
Compare
TheOneRing
force-pushed
the
work/redirects
branch
4 times, most recently
from
December 1, 2020 12:00
12b3e75
to
94e8903
Compare
TheOneRing
force-pushed
the
work/redirects
branch
4 times, most recently
from
December 8, 2020 10:39
10353fe
to
7bfb3ab
Compare
TheOneRing
changed the title
WIP: Don't follow redirects besides in the connection validator
Don't follow redirects besides in the connection validator
Dec 8, 2020
dschmidt
reviewed
Dec 8, 2020
.arg(Utility::escape(_ocWizard->account()->url().toString())); | ||
} else { | ||
errorMsg = job->errorStringParsingBody(); | ||
_ocWizard->show(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raiseDialog
?
test/testoauth.cpp
Outdated
@@ -349,26 +361,11 @@ private slots: | |||
{ | |||
OC_ASSERT(browserReply); | |||
// Kind of reproduces what we had in https://github.com/owncloud/enterprise/issues/2951 (not 1:1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check again what's up here
TheOneRing
force-pushed
the
work/redirects
branch
from
December 9, 2020 10:32
7bfb3ab
to
1094a98
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.