Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only]logout user from client #8663

Merged
merged 2 commits into from
Jun 3, 2021
Merged

[tests-only]logout user from client #8663

merged 2 commits into from
Jun 3, 2021

Conversation

swoichha
Copy link
Contributor

Description

This PR adds tests for:

  • logout user from client

Related Issue

@swoichha swoichha self-assigned this May 27, 2021
@swoichha swoichha force-pushed the test-user-logout branch 2 times, most recently from 1ed707b to 810024c Compare May 31, 2021 11:52
@swoichha swoichha marked this pull request as ready for review May 31, 2021 11:53
@swoichha swoichha requested review from Talank and dpakach May 31, 2021 11:53
@swoichha swoichha requested a review from Talank June 1, 2021 08:03
@swoichha swoichha requested a review from Talank June 1, 2021 11:38
@swoichha swoichha requested a review from Talank June 2, 2021 05:50
Talank
Talank reviewed Jun 2, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@Talank Talank requested a review from individual-it June 2, 2021 05:52
individual-it
individual-it reviewed Jun 2, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but all GUI tests fail :-(

@swoichha swoichha force-pushed the test-user-logout branch 2 times, most recently from 89b30e5 to 4e2a698 Compare June 3, 2021 04:16
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swoichha swoichha merged commit a2c2a29 into master Jun 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the test-user-logout branch June 3, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank left review comments

@individual-it individual-it individual-it approved these changes

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@swoichha swoichha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swoichha @individual-it @Talank