-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require exclusive locks for vfs and renames #8763
Conversation
1bceb47
to
660c05d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷🏻
660c05d
to
ccb4c4b
Compare
ccb4c4b
to
1a3787f
Compare
if (!FileSystem::isFileLocked(it.key(), it.value())) { | ||
qCInfo(lcLockWatcher) << "Lock of" << it.key() << "was released"; | ||
emit fileUnlocked(it.key()); | ||
unlocked.insert(it.key()); | ||
} | ||
} | ||
|
||
// Doing it this way instead of with a QMutableSetIterator | ||
// ensures that calling back into addFile from connected | ||
// slots isn't a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this comment is sufficient still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Fixes: #8761, #8754