Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] overwrite content of shared file #8814

Merged
merged 7 commits into from
Jul 21, 2021
Merged

Conversation

swoichha
Copy link
Contributor

Description

This PR adds gui test for overwrite content of a file shared by sharer

Related Issue

#8651

@swoichha swoichha self-assigned this Jul 14, 2021
@swoichha swoichha force-pushed the edit-share-file branch 2 times, most recently from 8274d8e to 3be0024 Compare July 16, 2021 11:29
@swoichha swoichha marked this pull request as ready for review July 20, 2021 09:04
@swoichha swoichha requested a review from Talank July 20, 2021 09:04
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Show resolved Hide resolved
f.write(content)
f.close()

print("file has been overwritten")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need that debug line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for log purpose in CI


@When('the user overwrites the file "|any|" with content "|any|"')
def step(context, resource, content):
print("starting file overwrite")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this debug line needed?

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit 968b133 into master Jul 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the edit-share-file branch July 21, 2021 13:42
dragotin pushed a commit that referenced this pull request Aug 10, 2021
* [tests-only] GUI tests to check the sync when overwriting the content of a shared file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants