Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests Only] add test for enable/disable vfs #8835

Merged
merged 5 commits into from
Aug 9, 2021
Merged

[Tests Only] add test for enable/disable vfs #8835

merged 5 commits into from
Aug 9, 2021

Conversation

swoichha
Copy link
Contributor

@swoichha swoichha commented Jul 21, 2021 •
edited
Loading

Description

This PR adds gui tests for enabling and diabling VFS

To-Do:

Find a way to verify if VFS has been enabled/disabled

Related Issue

@swoichha swoichha self-assigned this Jul 21, 2021
@swoichha swoichha added QA:team and removed qa-ready labels Jul 21, 2021
@swoichha swoichha force-pushed the tests-vfs branch 2 times, most recently from 699dd2f to 3d8d5d4 Compare July 22, 2021 10:37
@swoichha swoichha requested a review from Talank August 3, 2021 11:22
@swoichha swoichha marked this pull request as ready for review August 3, 2021 11:22
Talank
Talank reviewed Aug 3, 2021
View reviewed changes
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Show resolved Hide resolved
@swoichha swoichha requested a review from Talank August 4, 2021 04:42
Talank
Talank reviewed Aug 4, 2021
View reviewed changes
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
test/gui/shared/steps/steps.py Outdated Show resolved Hide resolved
@swoichha swoichha requested a review from Talank August 4, 2021 10:46
@swoichha swoichha mentioned this pull request Aug 5, 2021
Closed
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Talank
Talank approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash before merging.

@swoichha swoichha merged commit e9ae93e into master Aug 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the tests-vfs branch August 9, 2021 07:07
@swoichha swoichha mentioned this pull request Aug 9, 2021
Closed
TheOneRing pushed a commit that referenced this pull request Aug 9, 2021
@swoichha @TheOneRing
[Tests Only] add test for enable/disable vfs (#8835)
c625d2d 
* [Tests Only] add test for vfs

* add test for disabling vfs

* vfs object from model

* make code DRY

* added few comment for coordinates
dragotin pushed a commit that referenced this pull request Aug 10, 2021
@swoichha @dragotin
[Tests Only] add test for enable/disable vfs (#8835)
922ce3d 
* [Tests Only] add test for vfs

* add test for disabling vfs

* vfs object from model

* make code DRY

* added few comment for coordinates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank approved these changes

Assignees

@swoichha swoichha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swoichha @Talank