Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an ignored restore #8863

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Allow an ignored restore #8863

merged 3 commits into from
Aug 5, 2021

Conversation

TheOneRing
Copy link
Member

No description provided.

If the local permissions are not correct we perform a prohibited move
The move fails with 403 and creates a blacklist entry, but we might get the correct permissions for that file.

In the next sync the we don't retry the move as we have the correct permissions now so we want to restore the original file.
The original file however is now on the blacklist we mark the restoration as ignore and end up in findAndCancelDeletedJob

Fixes: #8837
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@dragotin dragotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactorings.

@TheOneRing TheOneRing merged commit a19c076 into master Aug 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/move_crash branch August 5, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants