Restart oauth on error #9275
Merged
Restart oauth on error #9275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/oauth
branch
from
57b24f2
to
0539db8
Compare
TheOneRing
force-pushed
the
work/oauth
branch
from
0539db8
to
fc5b73f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
erikjv
approved these changes
Dec 15, 2021
erikjv
reviewed
Jan 17, 2022
| @@ -0,0 +1,6 @@ | |||
| Bugfix: Always restart OAuth2 on error | |||
|
|
|||
| We now always restart the OAuth2 process once we got a result. | |||
There was a problem hiding this comment.
"We now always reset the OAuth2 status before processing the result of an authentication request."
It took me a bit to understand what the intention of this change was ;-)
There was a problem hiding this comment.
Its a bit late now after the release :P
How ever you can still provide a pull request for the change log item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9196