Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webfinger #9366

Closed
wants to merge 5 commits into from
Closed

Webfinger #9366

wants to merge 5 commits into from

Conversation

TheOneRing
Copy link
Member

@TheOneRing TheOneRing commented Jan 14, 2022

A branch based on v2.10.0 can be found here: https://github.com/owncloud/client/compare/v2.10.0...work/v2.10.0-webfinger?expand=1

A branch based on v2.10.0 https://github.com/owncloud/client/tree/work/v2.10.1-webfinger .
The change modifies the behavior of the wizard and therefor must not be merged.
The next major release will bring the feature as a branding option, the feature however depends on the rewrite of the Wizard.

@TheOneRing TheOneRing marked this pull request as draft January 14, 2022 14:43
@TheOneRing TheOneRing force-pushed the work/webfinger2 branch 2 times, most recently from ce290b6 to 1a7bb6d Compare January 18, 2022 12:48
@TheOneRing TheOneRing changed the title WIp Webfinger Jan 18, 2022
@TheOneRing TheOneRing force-pushed the work/webfinger2 branch 5 times, most recently from 0fbcc2c to c65691c Compare January 25, 2022 10:42
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions github-actions bot added the Stale label Mar 19, 2022
@TheOneRing TheOneRing added this to the 2.11 milestone Mar 21, 2022
@TheOneRing TheOneRing removed the Stale label Mar 24, 2022
@TheOneRing TheOneRing mentioned this pull request Mar 24, 2022
1 task
(cherry picked from commit 91a6519)
(cherry picked from commit c65691c)
(cherry picked from commit 67ff79e)
(cherry picked from commit 12e06aa)
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/12359/6/1
💥 The GUI tests failed.
GUI Logs: (https://cache.owncloud.com/public/owncloud/client/12359/guiReportUpload/index.html)
Server Logs: (https://cache.owncloud.com/public/owncloud/client/12359/guiReportUpload/serverlog.log)
Stacktrace: (https://cache.owncloud.com/public/owncloud/client/12359/guiReportUpload/stacktrace.log)
Screenshots:

@fmoc
Copy link
Contributor

fmoc commented Jul 6, 2022

For the record, parts of this branch have been merged already. Should we close this PR or do you want to pick it up again and rebase it on master?

@TheOneRing
Copy link
Member Author

This branch is not to be merged

fmoc pushed a commit that referenced this pull request Jul 6, 2022
This commit adds support Webfinger lookups in the wizard. This way,
enterprise customers who allow authorization against a variety of OpenID
Connect servers can set up a Webfinger server to have the client use the
right IdP.

The commit includes @TheOneRing's the Webfinger implementation from #9366.
fmoc pushed a commit that referenced this pull request Jul 7, 2022
This commit adds support Webfinger lookups in the wizard. This way,
enterprise customers who allow authorization against a variety of OpenID
Connect servers can set up a Webfinger server to have the client use the
right IdP.

The commit includes @TheOneRing's the Webfinger implementation from #9366.
@TheOneRing TheOneRing removed this from the 3.0 milestone Jul 8, 2022
fmoc pushed a commit that referenced this pull request Jul 8, 2022
This commit adds support Webfinger lookups in the wizard. This way,
enterprise customers who allow authorization against a variety of OpenID
Connect servers can set up a Webfinger server to have the client use the
right IdP.

The commit includes @TheOneRing's the Webfinger implementation from #9366.
fmoc pushed a commit that referenced this pull request Jul 8, 2022
This commit adds support Webfinger lookups in the wizard. This way,
enterprise customers who allow authorization against a variety of OpenID
Connect servers can set up a Webfinger server to have the client use the
right IdP.

The commit includes @TheOneRing's the Webfinger implementation from #9366.
fmoc pushed a commit that referenced this pull request Jul 13, 2022
This commit adds support Webfinger lookups in the wizard. This way,
enterprise customers who allow authorization against a variety of OpenID
Connect servers can set up a Webfinger server to have the client use the
right IdP.

The commit includes @TheOneRing's the Webfinger implementation from #9366.
fmoc pushed a commit that referenced this pull request Jul 13, 2022
This commit adds support Webfinger lookups in the wizard. This way,
enterprise customers who allow authorization against a variety of OpenID
Connect servers can set up a Webfinger server to have the client use the
right IdP.

The commit includes @TheOneRing's the Webfinger implementation from #9366.
fmoc pushed a commit that referenced this pull request Jul 13, 2022
This commit adds support Webfinger lookups in the wizard. This way,
enterprise customers who allow authorization against a variety of OpenID
Connect servers can set up a Webfinger server to have the client use the
right IdP.

The commit includes @TheOneRing's the Webfinger implementation from #9366.
fmoc pushed a commit that referenced this pull request Jul 29, 2022
This commit adds support Webfinger lookups in the wizard. This way,
enterprise customers who allow authorization against a variety of OpenID
Connect servers can set up a Webfinger server to have the client use the
right IdP.

The commit includes @TheOneRing's the Webfinger implementation from #9366.
TheOneRing pushed a commit that referenced this pull request Jul 29, 2022
This commit adds support Webfinger lookups in the wizard. This way,
enterprise customers who allow authorization against a variety of OpenID
Connect servers can set up a Webfinger server to have the client use the
right IdP.

The commit includes @TheOneRing's the Webfinger implementation from #9366.
@github-actions github-actions bot added the Stale label Aug 8, 2022
@TheOneRing TheOneRing closed this Aug 9, 2022
@TheOneRing TheOneRing deleted the work/webfinger2 branch August 17, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants