New wizard #9482
Merged
New wizard #9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
requested changes
Mar 7, 2022
src/gui/owncloudgui.cpp
Outdated
| }); | ||
|
|
||
| // bring settings dialog to front | ||
| raiseDialog(settingsDialog()); |
There was a problem hiding this comment.
Please call raiseDialog on the wizard window instead.
There was a problem hiding this comment.
Can do that. My best guess is that it was done like this before was that the wizard is modal to the settings, and they wanted to show both. I'm curious to find out how the windows will behave when calling raiseDialog on the modal dialog.
There was a problem hiding this comment.
Now that I don't raise the settings dialog but the wizard window, it won't be centered above the settings any more on multi-screen systems. I think that's been the motivation to implement this in the first place.
TheOneRing
reviewed
Mar 14, 2022
TheOneRing
reviewed
Mar 21, 2022
TheOneRing
reviewed
Mar 21, 2022
TheOneRing
reviewed
Mar 21, 2022
fmoc
force-pushed
the
work/new-wizard
branch
3 times, most recently
from
4b6e532
to
749f914
Compare
|
Just the GUI tests fail at the moment. Shouldn't block the merge. |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR presents a complete reimplementation of the existing wizard. Some preparation has been merged already, e.g., #9426 or #9422. The current state works and sets up accounts with servers that use OAuth2 and classic HTTP Basic authentication.
Some functionality has not been implemented yet:
The PR's commit history is still a mess at this point and will be cleaned up soon. Also, some copyright headers are still missing, etc. The code is ready for review, though.