[Tests-Only]Enabled screenshot of desktop on test failure #9518
Conversation
The capture and upload of screenshot is actually working, https://cache.owncloud.com/public/owncloud/client/11072/guiReportUpload/screenshots/user_changes_the_expiration_date_of_an_already_existing_public_link_for_folder_using_client-UI.png However, we still need to find an appropriate way to show all the images (May be dumping all those screenshots each time as comment would pollute the overview of the PR. On the other hand, rendering screenshots as a web page (like we displayed the GUI test result) might be better. |
Talank
force-pushed
the
GUI-test-error-screenshot
branch
from
c7f890d
to
22d6930
Compare
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/11080/5/1 |
Talank
force-pushed
the
GUI-test-error-screenshot
branch
from
36ee77e
to
3a4b873
Compare
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/11082/5/1 |
Talank
force-pushed
the
GUI-test-error-screenshot
branch
from
3a4b873
to
9db3773
Compare
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/11083/5/1 |
Talank
force-pushed
the
GUI-test-error-screenshot
branch
2 times, most recently
from
7f385bb
to
4847ffa
Compare
Talank
force-pushed
the
GUI-test-error-screenshot
branch
from
12a82ff
to
feeaa06
Compare
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/11101/5/1 |
Talank
force-pushed
the
GUI-test-error-screenshot
branch
from
feeaa06
to
20eddb6
Compare
| echo "creating comment for screenshots" | ||
| echo "Screenshots:" >> $1/comments.file | ||
| for i in $(ls $1/screenshots); do | ||
| echo "- [$i](${CACHE_ENDPOINT}/${CACHE_BUCKET}/$2/$3/guiReportUpload/screenshots/$i)" >> $1/comments.file |
There was a problem hiding this comment.
| echo "- [$i](${CACHE_ENDPOINT}/${CACHE_BUCKET}/$2/$3/guiReportUpload/screenshots/$i)" >> $1/comments.file | |
| echo "- [$i](${CACHE_ENDPOINT}/${CACHE_BUCKET}/$2/$3/${GUI_TEST_REPORT_DIR}/screenshots/$i)" >> $1/comments.file |
also $1 $2 $3 should be given nice names
both could happen in a different PR
There was a problem hiding this comment.
$GUI_TEST_REPORT_DIR is /drone/src/test/guiReportUpload. We either need to create new env variable to store the directory name guiReportUpload or we should leave it as it is, AFAIK.
And yes, we can give some nice name to all the variables, that can be done in some other PR.
| @@ -93,6 +93,24 @@ def hook(context): | |||
|
|
|||
| @OnScenarioEnd | |||
There was a problem hiding this comment.
that will create an screenshot AFTER the issue
so e.g. if the app crashes this will be the screen after the crash, meaning the app would not even be visible
Do we need (additionally?) the screenshot just before the problematic action? But that might be hard to achive
There was a problem hiding this comment.
If the app is not closed automatically after the crash then the screenshot is captured that shows the state of crash. For instance in #9518 (comment)
Otherwise, the only option that I can think of right now is to capture the video of test run (anyway) and then delete it if there is no test error. I can not say that can be done easily.
There was a problem hiding this comment.
But this could be a good enhancement. I will open an issue. May be we can try it later.
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/11125/5/1 |
Talank
force-pushed
the
GUI-test-error-screenshot
branch
from
71a047a
to
e3bf913
Compare
Talank
force-pushed
the
GUI-test-error-screenshot
branch
from
e3bf913
to
7e78b80
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This is how the comment looks like along with the screenshots #9518 (comment)
fixes: #9517