Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve URL placeholder in first wizard page #9720

Merged
merged 1 commit into from
May 24, 2022

Conversation

fmoc
Copy link
Contributor

@fmoc fmoc commented May 23, 2022

Fixes #9713.

@fmoc fmoc added this to the 3.0 milestone May 23, 2022
@fmoc fmoc requested a review from a team May 23, 2022 11:10
@ownclouders
Copy link
Contributor

ownclouders commented May 23, 2022

Results for GUI-tests https://drone.owncloud.com/owncloud/client/11885/6/1

💥 The GUI tests failed.

GUI Logs: https://cache.owncloud.com/public/owncloud/client/11885/guiReportUpload/index.html

Server Logs: https://cache.owncloud.com/public/owncloud/client/11885/guiReportUpload/serverlog.log

Screenshots:

@fmoc fmoc force-pushed the work/wizard-placeholder branch from 4e725d2 to 0586706 Compare May 23, 2022 11:45
@fmoc
Copy link
Contributor Author

fmoc commented May 23, 2022

Regarding the placeholder pointing to an actual domain, should we actually allow an empty value and fall back to the placeholder value?

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TheOneRing
Copy link
Member

Regarding the placeholder pointing to an actual domain, should we actually allow an empty value and fall back to the placeholder value?

Its only a hint, doing weird stuff if a user presses enter is ux from hell.
We could prefill the lineedit but also bad ux.

@TheOneRing TheOneRing merged commit 1fa04cc into master May 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/wizard-placeholder branch May 24, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard: Use demo.owncloud.com as placeholder
3 participants