-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to app password configuration #9755
Conversation
Regarding the screenshot, maybe we should move the new label above the |
maybe we could display the hint directly below the password line edit? |
Useful for connecting to oC 10 servers which use basic auth.
967a046
to
4759586
Compare
1st approach is better. I can provide more nitty-gritty refinements next week. |
Hm, I fear people mix up with the "Forgot my password" link and click-without-reading. Also - users will not know what an "app password" exactly is. Any link to help? |
Sadly branded clients don't provide doc and until now we don't have a solution for that. |
Just had a quick conversation with @tbsbdr discussing this problem. TL;DR: the text should be moved above the username/password form, below the "Enter your credentials" label. Some background: the old wizard placed it right above the form as well: There are two good reasons to move the app password link label into the proposed position: a) existing users are used to finding the link above the form |
I'll push my original proposal for now so it can be tested. I'd like to hear @TheOneRing and @dragotin's opinion. |
default: | ||
Q_UNREACHABLE(); | ||
} | ||
const QString usernameLabelText = []() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enumToStirng
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be easier to just add a helper to the theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, how to handle translations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes in the theme.
QCoreApplication::translate("enumName","foo")
747f9d0
to
8283edb
Compare
Kudos, SonarCloud Quality Gate passed! |
Fixes #9754.
The first commit fixes a minor issue introduced in #9746.