Add link to app password configuration #9755
Conversation
|
Regarding the screenshot, maybe we should move the new label above the |
maybe we could display the hint directly below the password line edit? |
|
Alternatively, this may work.
I'll push the first one for now. |
Useful for connecting to oC 10 servers which use basic auth.
fmoc
force-pushed
the
work/wizard-app-passwords
branch
from
967a046
to
4759586
Compare
|
1st approach is better. I can provide more nitty-gritty refinements next week. |
|
Hm, I fear people mix up with the "Forgot my password" link and click-without-reading. Also - users will not know what an "app password" exactly is. Any link to help? |
|
Sadly branded clients don't provide doc and until now we don't have a solution for that. |
|
Just had a quick conversation with @tbsbdr discussing this problem. TL;DR: the text should be moved above the username/password form, below the "Enter your credentials" label. Some background: the old wizard placed it right above the form as well:
There are two good reasons to move the app password link label into the proposed position: a) existing users are used to finding the link above the form
|
|
maybe put it even more "out of scope"? |
|
I'll push my original proposal for now so it can be tested. I'd like to hear @TheOneRing and @dragotin's opinion. |
| default: | ||
| Q_UNREACHABLE(); | ||
| } | ||
| const QString usernameLabelText = []() { |
There was a problem hiding this comment.
Might be easier to just add a helper to the theme?
There was a problem hiding this comment.
Also, how to handle translations?
There was a problem hiding this comment.
yes in the theme.
QCoreApplication::translate("enumName","foo")
fmoc
force-pushed
the
work/wizard-app-passwords
branch
from
747f9d0
to
8283edb
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Fixes #9754.
The first commit fixes a minor issue introduced in #9746.