Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Implement WITH_AUTO_UPDATER #9814

Merged
merged 1 commit into from
Jun 29, 2022
Merged

CMake: Implement WITH_AUTO_UPDATER #9814

merged 1 commit into from
Jun 29, 2022

Conversation

TheOneRing
Copy link
Member

Fixes: #9082

@TheOneRing TheOneRing requested review from dschmidt, fmoc and a team June 22, 2022 15:15
@TheOneRing TheOneRing added this to the 3.0 milestone Jun 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmoc fmoc merged commit 63ae3af into master Jun 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/auto_updater branch June 29, 2022 11:42
@dragotin
Copy link
Contributor

dragotin commented Jul 1, 2022

This needs to be documented in the client docs, there is a paragraph about building the client. @mmattel

Are there, apart from this switch, ohters that should be documented there?

@TheOneRing
Copy link
Member Author

They are already kind of documented in code.

client/CMakeLists.txt

Lines 80 to 105 in 3ae537b

# this option removes Http authentication, keychain, shibboleth etc and is intended for
# external authentication mechanisms
option(TOKEN_AUTH_ONLY "TOKEN_AUTH_ONLY" OFF)
option(NO_MSG_HANDLER "Don't redirect QDebug outputs to the log window/file" OFF)
# this option builds the shell integration
option(BUILD_SHELL_INTEGRATION "BUILD_SHELL_INTEGRATION" ON)
# this option builds/installs the generic shell integration icons
option(BUILD_SHELL_INTEGRATION_ICONS "BUILD_SHELL_INTEGRATION_ICONS" ON)
# this options builds the dolphin integration plugin
option(BUILD_SHELL_INTEGRATION_DOLPHIN "BUILD_SHELL_INTEGRATION_DOLPHIN" ON)
# this options builds the nautilus (like) integration plugins
option(BUILD_SHELL_INTEGRATION_NAUTILUS "BUILD_SHELL_INTEGRATION_NAUTILUS" ON)
# this option builds the client
option(BUILD_CLIENT "BUILD_CLIENT" ON)
# this option creates only libocsync and libowncloudsync (NOTE: BUILD_CLIENT needs to be on)
option(BUILD_LIBRARIES_ONLY "BUILD_LIBRARIES_ONLY" OFF)
# build the GUI component, when disabled only owncloudcmd is built
option(BUILD_GUI "BUILD_GUI" ON)

@TheOneRing
Copy link
Member Author

TOKEN_AUTH_ONLY is no longer supported and will be removed one day

@dragotin
Copy link
Contributor

dragotin commented Jul 1, 2022

They are already kind of documented in code.

yes, and with a cmake-guru-level above 8 people will find that ;-)

@TheOneRing
Copy link
Member Author

Those settings are available in the cmake gui and in most IDE's

@dragotin
Copy link
Contributor

dragotin commented Jul 1, 2022

Yes, I know. Sorry if I am stubborn: A good "How to build" documentation should mention the most important ones anyway, because packagers (that you want to help ;-) do not starts UIs for every program they are packaging.

WHAT the heck is the problem to add that to documentation? At least a hint?

@TheOneRing
Copy link
Member Author

I don't really have a problem with it, its just an other part of the documentation that can be outdated quite fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cmake option to disable auto updater
3 participants